Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.acebinf: remove; python3Packages.pyvcf: remove #232816

Merged
merged 2 commits into from
May 19, 2023

Conversation

natsukium
Copy link
Member

Description of changes

These libraries were introduced as dependencies of truvari but are no longer used.
pyvcf depends on use_2to3 and has been broken for over a year, so I removed them.

related #155516

cc @risicle, @scalavision

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This library was introduced as a dependency of "truvari" but is no
longer used.
Also, "pyvcf" on which it depends, cannot be built due to the removal of
"use_2to3".
This library was introduced as a dependency of "truvari" but is no
longer used.
Also, it can no longer be built due to the removal of "use_2to3".
@scalavision
Copy link
Contributor

Thanks! I agree, good to remove them, since they are not used.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 19, 2023
@wegank wegank merged commit 3ece3ad into NixOS:master May 19, 2023
@natsukium natsukium deleted the python3Packages.pyvcf/remove branch May 19, 2023 12:46
@tjni tjni mentioned this pull request Jun 14, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants